Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade axios to fix request chunked response #2182

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Upgrade axios to fix request chunked response #2182

merged 1 commit into from
Dec 9, 2024

Conversation

bertrandda
Copy link
Contributor

@bertrandda bertrandda commented Dec 9, 2024 •
edited
Loading

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

I upgraded axios to handle correctly API response with chunked data.

You can reproduce with timeapi.io api. Try to request https://timeapi.io/api/time/current/zone?timeZone=Europe%2FParis in scene request

Before upgrade
image

After upgrade
image

@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (2038265) to head (742ccf8).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2182   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         876      876           
  Lines       14409    14409           
=======================================
  Hits        14198    14198           
  Misses        211      211

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@relativeci RelativeCI
Copy link

relativeci bot commented Dec 9, 2024

#2914 Bundle Size — 10.41MiB (0%).

742ccf8(current) vs 2038265 master#2909(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
#2914		      Baseline
#2909
No change  Initial JS 5.64MiB 5.64MiB
No change  Initial CSS 304.89KiB 304.89KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 51 51
No change  Assets 173 173
No change  Modules 1511 1511
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
#2914		      Baseline
#2909
No change  JS 7.43MiB 7.43MiB
No change  IMG 2.54MiB 2.54MiB
No change  CSS 321.79KiB 321.79KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.79KiB 17.79KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis report Branch bertrandda:fix/axios-response-ch... Project dashboard

Generated by RelativeCI Documentation Report issue

Pierre-Gilles
Pierre-Gilles approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Pierre-Gilles Pierre-Gilles merged commit f85f2bf into GladysAssistant:master Dec 9, 2024
9 checks passed
@bertrandda bertrandda deleted the fix/axios-response-chunked branch December 10, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Gilles Pierre-Gilles Pierre-Gilles approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertrandda @Pierre-Gilles